fix: Incorrect subscribers param filtering #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcho
commented
Sep 24, 2023
| @@ -13,7 +13,7 @@ interactions: | |||
| User-Agent: | |||
| - MailerLite-Python-SDK-Client | |||
| method: GET | |||
| uri: https://connect.mailerlite.com/api/subscribers?limit=10&page=1 | |||
| uri: https://connect.mailerlite.com/api/subscribers?limit=10&cursor=abc123 | |||
There was a problem hiding this comment.
You are leaking some email addresses in your cassettes, which I didn't want to do so I just manually updated the cassettes to get tests passing
michaelcho
commented
Sep 24, 2023
| @@ -95,13 +95,19 @@ def test_api_url_is_properly_set(self): | |||
| "tests/vcr_cassettes/subscribers-list.yml", filter_headers=["Authorization"] | |||
| ) | |||
| def test_list_of_all_subscribers_should_be_returned(self, subscriber_keys): | |||
| response = self.client.subscribers.list(limit=10, page=1) | |||
| response = self.client.subscribers.list(limit=10, cursor="abc123") | |||
There was a problem hiding this comment.
Perhaps a better test case would also assert that results are different when passing in different cursors, but as mentioned in another comment I didn't want to leak my actual email addresses in the cassettes
michaelcho
commented
Sep 24, 2023
| @@ -13,7 +13,7 @@ interactions: | |||
| User-Agent: | |||
| - MailerLite-Python-SDK-Client | |||
| method: GET | |||
| uri: https://connect.mailerlite.com/api/subscribers?limit=10&page=1 | |||
| uri: https://connect.mailerlite.com/api/subscribers?limit=10&cursor=abc123 | |||
There was a problem hiding this comment.
Meta - perhaps your API endpoints should have a version number in the URL, so that your SDKs can be versioned to the API endpoints. Otherwise every time you change your API contract I dunno how you'll keep SDKs updated / backward-compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get this api endpoint to actually paginate without using the
cursorparam described in your API docs