Use compare_digest in Python when comparing hex digests (#196)

mailgun · Dec 1, 2016 · e8b9270 · e8b9270
1 parent f267d54
commit e8b9270
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/source/user_manual.rst b/source/user_manual.rst
@@ -725,10 +725,10 @@ Below is a Python code sample used to verify the signature:
     import hashlib, hmac
 
     def verify(api_key, token, timestamp, signature):
-        return signature == hmac.new(
-                                 key=api_key,
-                                 msg='{}{}'.format(timestamp, token),
-                                 digestmod=hashlib.sha256).hexdigest()
+        hmac_digest = hmac.new(key=api_key,
+                               msg='{}{}'.format(timestamp, token),
+                               digestmod=hashlib.sha256).hexdigest()
+        return hmac.compare_digest(unicode(signature), unicode(hmac_digest))
 
 
 And here's a sample in Ruby: