Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement batch get service #29

Closed
wants to merge 9 commits into from
Closed

Conversation

haifeiWu
Copy link

@haifeiWu haifeiWu commented Mar 3, 2021

implement batch get service

@thrawn01
Copy link
Contributor

We shouldn't change the interface, we should instead have the standard interface batch many requests to the same machine if they all come in around the same time. We do this in gubernator which you can see here. https://github.com/mailgun/gubernator/blob/master/peer_client.go#L272-L312

Additionally this feature should be optional, as batching requests means we are trading latency for throughput and some users might care more about latency.

@haifeiWu
Copy link
Author

Ok, let me change the way of implementation

@thrawn01
Copy link
Contributor

thrawn01 commented Jul 6, 2022

closing due to age

@thrawn01 thrawn01 closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants