Add HTTP error message from peer to error returned from httpGetter.Get #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarnixBouhuis
force-pushed
the
add-peer-error-message-to-error
branch
from
09bd4ad
to
131b5ec
Compare
thrawn01
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errors returned when making requests to peers only contain the status code returned by the peer. Most of the time this will be a 500 error. The real error reason is returned by the peer in the response body.
This PR adds the error message from the peer to the error returned by the
httpGetter.Getmethod. I've limited the error message to max 10 MiB to limit to prevent possible chaos when peers start returning errors of multiple GB's or something 😃.