Fix LRU to correctly evict cache items when replaced #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
group.Set
is called, if the key already exists in acache
instance, thennbytes
is not updated correctly sinceOnEvicted
is not called.This means the cache slow leaks memory eventually being unable to cache any items.
To fix this, this PR updates the lru cache to call
OnEvicted
when replacing the value of an existing key.