This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Security update golang.org/x/net and Tidy code #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baliedge
force-pushed
the
Baliedge/PIP-2675-global-fix
branch
from
072742b
to
b2b697d
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-global-fix
branch
from
c6e0991
to
b3f5a18
Compare
Every `GetRateLimit()` was resulting in an async hit AND broadcast. This does not follow the architecture described in architecture.md.
Baliedge
force-pushed
the
Baliedge/PIP-2675-global-fix
branch
from
7ca2f0f
to
865ef99
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-global-fix
branch
from
f9aeb3f
to
6108420
Compare
Baliedge
changed the title
getLocalRateLimit().
thrawn01
approved these changes
Oct 12, 2023
Baliedge
force-pushed
the
Baliedge/PIP-2675-global-fix
branch
from
3238249
to
4b231d4
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-global-fix
branch
from
4b231d4
to
19ea39c
Compare
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0. - [Commits](golang/net@v0.10.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestGlobalRateLimitsthat was not checking for exact behavior.GlobalManagerfields so that tests would not read from global metric variables that were impacted by other tests.GlobalSyncWaitfrom 500ms to 100msrunAsyncHits()andrunBroadcasts(). When a ratelimit is hit, it could take up to 2x this setting before it's replicated to each peer.