This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
docs: add docs in global.go
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baliedge
suggested changes
Feb 19, 2024
global.go
Outdated
| @@ -65,29 +65,32 @@ func newGlobalManager(conf BehaviorConfig, instance *V1Instance) *globalManager | |||
| Help: "The count of requests queued up for global broadcast. This is only used for GetRateLimit requests using global behavior.", | |||
| }), | |||
| } | |||
| gm.runAsyncHits() | |||
| gm.runBroadcasts() | |||
| gm.toOwners() | |||
There was a problem hiding this comment.
I see the confusion around the original names. Would prefer a more <Verb><Noun> nomenclature.
How about:
gm.runAsyncHits()->gm.runBatches()
I think runBroadcasts() is appropriately named.
Thoughts?
There was a problem hiding this comment.
No, for me it's still confusing, because i'm missing out on who is doing the action.
There was a problem hiding this comment.
It's implied the current peer is doing the action. Both of these start a goroutine that process these actions.
miparnisari
changed the title
global.go
Baliedge
approved these changes
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #208 I did a bunch of renames that made me understand the code more easily.