This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Fix goroutine leak in Instance.SetPeers
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reuse any existing connections to a peer before opening a new one 2. Add ability to gracefully shutdown any PeerClients 3. Shutdown PeerClients that are no longer needed
Use a `sync.WaitGroup` to keep track of in-flight requests, and wait until either the `WaitGroup` has finished or the `Context` has been cancelled before returning.
|
Can one of the admins verify this patch? |
thrawn01
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
This is fantastic code and a much needed improvement. Thanks for working on this!
The only thing missing is gubernator.go calls to GetPerrRateLimits() and UpdatePeerGlobals() should look for ErrClosing and attempt to get a new peer. (with retry limits). I don't wanna hold up this PR so I'm gonna merge and make those changes in a separate PR I'll @ mention you on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #26 through the following changes:
I've been running it in a test environment with both traffic and a volatile peer set, and can confirm that this fixes leaking goroutines issue we were seeing earlier.