Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

PIP-823: Refactor and Improvements for v1.0.0 #55

Merged
merged 6 commits into from
Oct 28, 2020

Conversation

thrawn01
Copy link
Contributor

@thrawn01 thrawn01 commented May 8, 2020

Purpose

To prepare for the 1.0.0 release. This PR changes the names of public methods and config options to provide a more consistent interface.

Config Changes

  • Added GUBER_DATA_CENTER
  • Use GUBER_PEER_DISCOVERY_TYPE to pick a peer discovery type
  • Added GUBER_ADVERTISE_ADDRESS to specify which address is published for discovery
  • Gubernator now attempts to detect the proper GUBER_ADVERTISE_ADDRESS if not specified
  • Added DataCenter to member-list and etcd metadata

Implementation

  • Added GUBER_DATA_CENTER as a config option
  • Use GUBER_PEER_DISCOVERY_TYPE to pick a peer discovery type, removed
    'Enable' options from k8s, etcd, and member-list.
  • Added GUBER_ADVERTISE_ADDRESS to specify which address is published for discovery
  • Gubernator now attempts to detect the proper GUBER_ADVERTISE_ADDRESS if not specified
  • Gubernator now binds to localhost by default instead of binding to 0.0.0.0:80 to avoid allowing
    access to a test version of gubernator from the network.
  • Fix inconsistent tests failing TestLeakyBucket & TestTokenBucket fails occasionally. #57
  • Fix GRPC/HTTP Gateway /v1/HealthCheck dials default EtcdAdvertiseAddress even though only kubernetess is configured. #50
  • Renamed functions to ensure clarity of version
  • Removed deprecated EtcdAdvertiseAddress config option
  • Refactored configuration options
  • member-list metadata no longer assumes the member-list address is the same
    as the gubernator advertise address.
  • Now MD5 sums the peer address key when using replicated hash. This ensures
    better key distribution when using domain names or ip address that are very
    similar. (gubernator-1, gubernator-2, etc...)
  • Now defaults to replicated-hash if GUBER_PEER_PICKER is unset
  • Added support for DataCenter fields when using etcd discovery
  • Refactored cluster package to so we can test the full daemon instead of an isolated instance of Gubernator.
  • Now storing member-list metadata as JSON instead of glob

@thrawn01 thrawn01 self-assigned this May 8, 2020
@thrawn01 thrawn01 changed the title Adding GRPC Gateway tests PIP-823: Adding GRPC Gateway tests May 11, 2020
@nipak
Copy link

nipak commented Jul 7, 2020

Any update on merging this?

@thrawn01
Copy link
Contributor Author

I've not forgotten about this! I have other priorities currently so I might be a challenge to find time to finish this month, if anyone is interested in rebasing this work and continuing It in a different branch, It would be most appreciated.

@thrawn01 thrawn01 force-pushed the thrawn/test-grpc-gateway branch 6 times, most recently from f27df52 to 5882338 Compare October 22, 2020 02:03
@thrawn01 thrawn01 changed the title PIP-823: Adding GRPC Gateway tests PIP-823: Refactor and Improvements for v1.0.0 Oct 23, 2020
@thrawn01 thrawn01 requested a review from mkbond October 23, 2020 21:28
@thrawn01 thrawn01 force-pushed the thrawn/test-grpc-gateway branch 2 times, most recently from fc29810 to 37d2608 Compare October 23, 2020 21:29
@thrawn01 thrawn01 marked this pull request as ready for review October 26, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants