This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
PIP-823: Refactor and Improvements for v1.0.0 #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To prepare for the 1.0.0 release. This PR changes the names of public methods and config options to provide a more consistent interface.
Config Changes
GUBER_DATA_CENTER
GUBER_PEER_DISCOVERY_TYPE
to pick a peer discovery typeGUBER_ADVERTISE_ADDRESS
to specify which address is published for discoveryGUBER_ADVERTISE_ADDRESS
if not specifiedDataCenter
tomember-list
andetcd
metadataImplementation
GUBER_DATA_CENTER
as a config optionGUBER_PEER_DISCOVERY_TYPE
to pick a peer discovery type, removed'Enable' options from k8s, etcd, and member-list.
GUBER_ADVERTISE_ADDRESS
to specify which address is published for discoveryGUBER_ADVERTISE_ADDRESS
if not specifiedlocalhost
by default instead of binding to0.0.0.0:80
to avoid allowingaccess to a test version of gubernator from the network.
EtcdAdvertiseAddress
config optionmember-list
metadata no longer assumes the member-list address is the sameas the gubernator advertise address.
better key distribution when using domain names or ip address that are very
similar. (gubernator-1, gubernator-2, etc...)
replicated-hash
ifGUBER_PEER_PICKER
is unsetcluster
package to so we can test the full daemon instead of an isolated instance of Gubernator.