Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: testmode #160

Closed
elnygren opened this issue Aug 14, 2017 · 3 comments
Closed

feature request: testmode #160

elnygren opened this issue Aug 14, 2017 · 3 comments
Assignees

Comments

@elnygren
Copy link

Apparently Mailgun charges for testmode sends too. Could this library implement a testmode setting that can be flipped during unit tests to prevent unnecessary API calls / stubbing HTTP requests?

@bojand bojand self-assigned this Aug 15, 2017
@zoellner
Copy link

I'd suggest to extend this to the point where it doesn't do any api calls but just logs what it would do. Would be helpful for us to turn on during some local test/dev where the mailgun api key is not available

bojand added a commit that referenced this issue Oct 25, 2018
@bojand
Copy link
Collaborator

bojand commented Oct 25, 2018

Hello, please take a look #225 and provide some feedback, and I'll merge and publish soon if OK.

@zoellner
Copy link

This would work for our use case

@bojand bojand closed this as completed in 106420e Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants