CS and fixes

mailgun · Jan 12, 2019 · 0f54332 · 0f54332
1 parent 2ec2c16
commit 0f54332
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 28 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -30,7 +30,7 @@ matrix:
           script: ./vendor/bin/roave-backward-compatibility-check || true
         - name: PHPStan
           php: 7.2
-          env: DEPENDENCIES="phpstan/phpstan phpstan/phpstan-webmozart-assert"
+          env: DEPENDENCIES="phpstan/phpstan"
           script: ./vendor/bin/phpstan analyse src
 
 before_install:

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,3 @@
 parameters:
 	level: 5
 
-includes:
-	- vendor/phpstan/phpstan-webmozart-assert/extension.neon
diff --git a/src/Api/EmailValidation.php b/src/Api/EmailValidation.php
@@ -70,7 +70,7 @@ public function validate(string $address, bool $mailboxVerification = false)
      * This operation is only accessible with the private API key and not subject to the daily usage limits.
      *
      * @param string $addresses  A delimiter separated list of addresses. Maximum: 8000 characters.
-     * @param bool|  $syntaxOnly Perform only syntax checks or DNS and ESP specific validation as well.
+     * @param bool   $syntaxOnly Perform only syntax checks or DNS and ESP specific validation as well.
      *                           The default is True.
      *
      * @throws InvalidArgumentException Thrown when local validation returns an error

diff --git a/src/Model/EmailValidation/Parts.php b/src/Model/EmailValidation/Parts.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * Copyright (C) 2013 Mailgun
  *
@@ -29,17 +31,11 @@ final class Parts
      */
     private $localPart;
 
-    /**
-     *
-     */
     private function __construct()
     {
     }
 
-
     /**
-     * @param array $data
-     *
      * @return Parts
      */
     public static function create(array $data)
@@ -52,25 +48,16 @@ public static function create(array $data)
         return $model;
     }
 
-    /**
-     * @return null|string
-     */
     public function getDisplayName(): ?string
     {
         return $this->displayName;
     }
 
-    /**
-     * @return null|string
-     */
     public function getDomain(): ?string
     {
         return $this->domain;
     }
 
-    /**
-     * @return null|string
-     */
     public function getLocalPart(): ?string
     {
         return $this->localPart;

diff --git a/src/Model/EmailValidation/ValidateResponse.php b/src/Model/EmailValidation/ValidateResponse.php
@@ -12,7 +12,6 @@
 namespace Mailgun\Model\EmailValidation;
 
 use Mailgun\Model\ApiResponse;
-use Mailgun\Model\EmailValidation\EmailValidation;
 
 /**
  * @author David Garcia <me@davidgarcia.cat>

diff --git a/tests/Model/EmailValidation/ParseResponseTest.php b/tests/Model/EmailValidation/ParseResponseTest.php
@@ -2,10 +2,16 @@
 
 declare(strict_types=1);
 
+/*
+ * Copyright (C) 2013 Mailgun
+ *
+ * This software may be modified and distributed under the terms
+ * of the MIT license. See the LICENSE file for details.
+ */
+
 namespace Mailgun\Tests\Model\EmailValidation;
 
 use Mailgun\Model\EmailValidation\ParseResponse;
-use Mailgun\Model\EmailValidation\ValidateResponse;
 use Mailgun\Tests\Model\BaseModelTest;
 
 class ParseResponseTest extends BaseModelTest
@@ -31,7 +37,6 @@ public function testCreate()
 
     public function testParseConstructorWithValidData()
     {
-
         $data = [
             'parsed' => ['parsed data'],
             'unparseable' => ['unparseable data'],
@@ -45,7 +50,6 @@ public function testParseConstructorWithValidData()
 
     public function testParseConstructorWithInvalidData()
     {
-
         $data = [
             'parsed' => null,
             'unparseable' => null,
@@ -56,5 +60,4 @@ public function testParseConstructorWithInvalidData()
         $this->assertEquals([], $parts->getParsed());
         $this->assertEquals([], $parts->getUnparseable());
     }
-
 }
diff --git a/tests/Model/EmailValidation/PartsTest.php b/tests/Model/EmailValidation/PartsTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * Copyright (C) 2013 Mailgun
  *
@@ -16,7 +18,6 @@ class PartsTest extends BaseModelTest
 {
     public function testPartsConstructor()
     {
-
         $data = [
             'display_name' => ' Display name',
             'domain' => 'Domain',

diff --git a/tests/Model/EmailValidation/ValidateResponseTest.php b/tests/Model/EmailValidation/ValidateResponseTest.php
@@ -2,6 +2,13 @@
 
 declare(strict_types=1);
 
+/*
+ * Copyright (C) 2013 Mailgun
+ *
+ * This software may be modified and distributed under the terms
+ * of the MIT license. See the LICENSE file for details.
+ */
+
 namespace Mailgun\Tests\Model\EmailValidation;
 
 use Mailgun\Model\EmailValidation\Parts;
@@ -30,7 +37,6 @@ public function testCreate()
 JSON;
         $model = ValidateResponse::create(json_decode($json, true));
         $this->assertTrue($model->isMailboxVerification());
-
     }
 
     public function testCreateWithoutMailboxVerification()
@@ -54,12 +60,10 @@ public function testCreateWithoutMailboxVerification()
 JSON;
         $model = ValidateResponse::create(json_decode($json, true));
         $this->assertFalse($model->isMailboxVerification());
-
     }
 
     public function testEmailValidation()
     {
-
         $data = [
             'address' => 'foo@mailgun.net',
             'did_you_mean' => null,