Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan checks #529

Closed
Nyholm opened this issue Jan 7, 2019 · 4 comments · Fixed by #530
Closed

Add phpstan checks #529

Nyholm opened this issue Jan 7, 2019 · 4 comments · Fixed by #530

Comments

@Nyholm
Copy link
Collaborator

Nyholm commented Jan 7, 2019

I want to try @OskarStark’s github action: https://github.com/OskarStark/phpstan-ga

What do you think? Should we try to see if phpstan can help us while reviewing PRs?

@OskarStark
Copy link

Nice 👍

Let me know when I can support you, but first we need ti find out, if mailgun organization is invited to the beta (and is currently available for "organizations" 🤔 )

@Nyholm
Copy link
Collaborator Author

Nyholm commented Jan 7, 2019

Oh, I thought it was just to make a PR like #530 and it would magically turn up in the PR's "Checks".

@OskarStark
Copy link

You are right, from this moment, where Github will allow/activate Github Actions for everyone or at least public organization repositories it will work

@OskarStark
Copy link

As I am using FROM phpstan/phpstan:0.10 docker image as base, it is not possible to use phpstan extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants