Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHPStan action #530

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Added PHPStan action #530

merged 1 commit into from
Jan 9, 2019

Conversation

Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented Jan 7, 2019 •
edited
Loading

This will fix #529

This has to wait until the Github has rolled out the "Github action" feature for the mailgun organization.

@Nyholm Nyholm mentioned this pull request Jan 7, 2019
Closed
@OskarStark OskarStark mentioned this pull request Jan 7, 2019
Closed
DavidGarciaCat
DavidGarciaCat approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@DavidGarciaCat DavidGarciaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can give it a try, maybe suits our needs :-)

@Nyholm Nyholm merged commit fb9892f into mailgun:master Jan 9, 2019
@Nyholm Nyholm deleted the github-action-phpstan branch January 9, 2019 19:36
@Nyholm
Copy link
Collaborator Author

Nyholm commented Jan 9, 2019

This has to wait until the Github has rolled out the "Github action" feature for the mailgun organization.

No, we can just merge now and watch it magically appear later =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@DavidGarciaCat DavidGarciaCat DavidGarciaCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add phpstan checks
3 participants
@Nyholm @OskarStark @DavidGarciaCat