Fixed inline/attachment issue. Added new tests. #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return array | ||
| */ | ||
| protected function prepareFile($fieldName, $filePath) | ||
| protected function prepareFile($fieldName, $filePath, $fileIndex=0) |
|
Thank you @travelton. This is a great PR. Im not happy with how you write the tests. I think that is a hack. But your point is valid. I'll send a PR shortly that achieve the same goals with the tests. Give me a moment and I'll have something to show |
Merged
|
See #153. |
|
@Nyholm Agreed, totally hacky. Removing my tests. Once you have your tests merged, I'll rebase this PR and write some tests for it. |
travelton
force-pushed
the
travis/FixInlines
branch
from
9ead25c
to
4380fce
Compare
travelton
force-pushed
the
travis/FixInlines
branch
from
4380fce
to
d459c59
Compare
|
Awesome. Im glad you liked it. I've merged the #153 now |
|
Merged by #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Friends!
This pull request fixes a multi inline/attachment issue. Some HTTP clients cannot handle url encoded form data with the same key and different value. With the current implementation, if you pass in multiple inline/attachment values, only the last value in the array is actually sent to the Mailgun API.
We need to give the key an "index marker" (for lack of better term?). The Mailgun API knows how to handle this...
Example (Bad):
Example (Good):
Also, tests. I'm including my lame attempt at revamping the tests a bit. Eventually, every test should probably follow something like this, so as to test between request and "$client->send()". Happy to entertain any community suggestions here. We really need to beef up the tests on this SDK.