Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump year updating Copyright #391

Closed
wants to merge 1 commit into from
Closed

Conversation

shakaran
Copy link
Contributor

This could be easily achieved in next years with the following bash command and changing the years:

grep -l "2013-2016" | xargs sed -i 's/2013-2016/2013-2017/g'

@Nyholm
Copy link
Collaborator

Nyholm commented Aug 30, 2017

Thank you. But this is controlled by style CI. I have a task for admin (@pirogoeth) to update the StyleCI settings for file headers: #343

@Nyholm Nyholm closed this Aug 30, 2017
@shakaran
Copy link
Contributor Author

@Nyholm since style CI is not supported with php-cs-fixer 2.x versions, StyleCI still will control this? Even if controlled or not, it needs to be updated properly, so I think that the ideal should be merge or at least upgrade .php_cs to use php-cs-fixer 2.x and update the headers

@DavidGarciaCat
Copy link
Collaborator

Hey @shakaran - What @Nyholm means is this repository is inspected by Style CI when new commits are pushed, and the PHP headers that contain the years are part of the Style CI settings, so there's no need to apply this PR.

@shakaran
Copy link
Contributor Author

@DavidGarciaCat but since Style CI is not working(because not support for PHP-CS-Fixer 2.x branch) (or at least is not commiting and updating in old files), it never gets updated or I am wrong with that statment?

@DavidGarciaCat
Copy link
Collaborator

Hey @shakaran - As @Nyholm said, issue #343 is related, and he has sent already a reminder to @pirogoeth via Gitter, asking if he can deal with this request, so there is no need to keep this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants