Fix for #71: Show response message on 400, 401 and 404. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the actual response message to the errors thrown on 400, 401 and 404 response codes. This provides a lot more useful info than the current messages. The message doesn’t really give you much to go one. I spent hours trying to find what I did wrong, double checking my API keys and looking up the error on google.
|
Fix for #49, #67 and #71 |
Also removed the 401, since that one doesn’t need it.
|
You can blame @Bogardo for that last commit. |
|
I take full responsibility ;) |
|
@travelton What is the status on this? |
|
Sorry all, @travelton isn't on this project anymore, but I am. Sorry for the delay, let me test this out! |
|
@jessespears Any news on this? |
jessespears
pushed a commit
that referenced
this pull request
May 5, 2015
Fix for #71: Show response message on 400, 401 and 404.
|
Thanks for the PR, and sorry for the delay! |
|
No problem, and most welcome! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the actual response message to the errors thrown on 400, 401 and
404 response codes. This provides a lot more useful info than the
current messages. The message doesn’t really give you much to go on. I
spent hours trying to find what I did wrong, double checking my API
keys and looking up the error on google.