Attachments are ignoring filename when sent using ActionMailer

[rmcsharry]

I have Rails 5.0.1 using ActionMailer code as follows:

  def pdf_quote(proposal)
    @proposal = proposal
    email_with_name = %("#{@proposal.first_name} #{@proposal.last_name}" <#{@proposal.email}>)
    @filename = "QD-#{@proposal.qd_number}_#{@proposal.last_name}.pdf"
    attachments[@filename] = {
      mime_type: 'application/pdf',
      encoding: 'Base64',
      content: @proposal.pdf_base64
    }  
    mail(
      to: email_with_name,
      from: 'Floorbook UK <email address>',
      subject: 'Your Personal Flooring Quote is attached',
      sent_on: Time.now
      )    
  end

I have tried by hardcoding 'test.pdf' also. I have tried replace flilename: with remoteName inside the hash (as I see th PHP plugin uses remoteName).

No matter what I try the filename does not appear in the JSON in the mailgun logs.

I can however see it in the Rails log. For example, here is the log when I tried using remotename:

----==_mimepart_58acb0bbc5906_b35a3ff9c303fa14374b
Content-Type: application/pdf
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename=QD-1002_McSharry.pdf
remotename: QD-1002_McSharry.pdf
Content-ID: <58acb0bbc8aaf_b35a3ff9c303fa14376d9@Richards-MacBook-Air.local.mail>

%PDF-1.3

Here is the relevant part of the JSON from the mailgun log:

"message": {
"headers": {
"to": "Richard McSharry ",
"message-id": "20170221213251.124698.55612.AAE859F0@sandbox4d05645e78ac4c81b7b542d27c5e87ad.mailgun.org",
"from": "Floorbook UK ",
"subject": "Your Personal Flooring Quote is attached"
},
"attachments": [
{
"filename": "",
"content-type": "application/pdf",
"size": 9004
}
],
"recipients": [
"my email"
],
"size": 11517
},

[pirogoeth]

@rmcsharry I'm assuming this is with the new Railgun code / version 1.1.4 of the gem?

[rmcsharry]

Yes - mailgun-ruby (1.1.4). I also tested with Postman and the filename there shows up as 'pd_mime_attachment'.

So it seems both gmail and postman see that the filename is empty and substitute a default value.

I suppose it could be ActionMailer doing this, but then surely Stack Overflow would be swamped with questions about this? It used to happen in Rails 3. I've opened a question anyway for Rails 5 to see if anyone else has seen this in ActionMailer specifically.

[pirogoeth]

@rmcsharry I will look in to this, it very well could be an issue with Railgun. I'll let you know what I find :)

[pirogoeth]

@rmcsharry I think I found the issue. Stand by for a PR.

[rmcsharry]

@pirogoeth Awesome, thanks for the quick fix. I just tested it and it works! :)

[pirogoeth]

@rmcsharry Awesome! I'll cut an official release on Monday :)

[rmcsharry]

@pirogoeth This branch I tested was labelled as version 1.1.5. But now that you have merged it, the version of master branch did not change, it is still 1.1.4 - was that the intention?

[pirogoeth]

@rmcsharry It seems that 1.1.5 has been released to Rubygems and 1.1.5 is in master (tagged as v1.1.5)..

[rmcsharry]

Ok thanks I just removed it from my project and bundle installed again, now it shows up as 1.1.5. Thanks for confirming!

[pirogoeth]

Of course!

[pavanscs]

new issues can any one please help me with this i want a attachment file that was send to the mailer has to be open in a new tab is it possible to make the pdf file to open in a new tab