Include config info in README for EU domains #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I struggled for about an hour before realising my domain was configured in `eu`.
vickodin
reviewed
Oct 10, 2019
| @@ -74,6 +74,7 @@ and replace `api-myapikey` and `mydomain.com` with your secret API key and domai | |||
| config.action_mailer.mailgun_settings = { | |||
| api_key: 'api-myapikey', | |||
| domain: 'mydomain.com', | |||
| # api_host: 'api.eu.mailgun.net' # Uncomment this line for EU region domains | |||
vickodin
approved these changes
Oct 10, 2019
|
That would have saved me an hour as well (I was about to click the |
|
@vickodin anything more I can do to get this merged? |
|
Thanks for making this PR, We currently do not have a dedicated ruby dev to monitor this repo, sorry this took so long to merge. |
This was referenced Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled for about an hour before realising my domain was configured in
eu. This extra info in the readme should help others.NB. This pull request should also close #163