Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include config info in README for EU domains #174

Merged
merged 1 commit into from Dec 14, 2019
Merged

Conversation

@jaredlt
Copy link
Contributor

jaredlt commented Aug 27, 2019

I struggled for about an hour before realising my domain was configured in eu. This extra info in the readme should help others.

NB. This pull request should also close #163

I struggled for about an hour before realising my domain was configured in `eu`.
@@ -74,6 +74,7 @@ and replace `api-myapikey` and `mydomain.com` with your secret API key and domai
config.action_mailer.mailgun_settings = {
api_key: 'api-myapikey',
domain: 'mydomain.com',
# api_host: 'api.eu.mailgun.net' # Uncomment this line for EU region domains

This comment has been minimized.

Copy link
@vickodin
@francois-ferrandis

This comment has been minimized.

Copy link

francois-ferrandis commented Oct 31, 2019

That would have saved me an hour as well (I was about to click the Create ticket button to send that request about this "Domain not found" error). 😄

@jaredlt

This comment has been minimized.

Copy link
Contributor Author

jaredlt commented Nov 1, 2019

@vickodin anything more I can do to get this merged?

@vickodin

This comment has been minimized.

Copy link

vickodin commented Nov 1, 2019

@vickodin anything more I can do to get this merged?

@jaredlt I don't know. I just want too to merge this PR )
But it looks good in any case and enough for stop spending other developers' time, include me.

Good luck!

@thrawn01 thrawn01 merged commit 75be1cc into mailgun:master Dec 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thrawn01

This comment has been minimized.

Copy link

thrawn01 commented Dec 14, 2019

Thanks for making this PR, We currently do not have a dedicated ruby dev to monitor this repo, sorry this took so long to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.