Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra splitter expressions and tests for German #23

Closed
wants to merge 13 commits into from

Conversation

sspross
Copy link

@sspross sspross commented Nov 26, 2014

As I mentioned in #22, please tell me if this is how you do locale stuff.

And I'm very sorry, but I couldn't manage to run the tests because of PyML compiling problems. If you tell me how I can manage this on MacOS, I'll get this running. And I guess the test test_pattern_from_block_german should still fail at the moment.

Just tell me what to do, I'm happy to help!

@sspross sspross mentioned this pull request Nov 27, 2014
@jeremyschlatter
Copy link
Contributor

Hello!

Thanks for working on this. I wanted to add Danish support today and saw that you had this pull request open, so I made a German+Danish patch at #29. My patch does not touch RE_ON_DATE_SMB_WROTE or the <date> <person> regex, but I think I merged the rest.

@sspross
Copy link
Author

sspross commented Dec 24, 2014

Thanks for merging, sorry didn't recognized you're an owner :) At the moment this pull requests breaks some tests. My changes on RE_ON_DATE_SMB_WROTE are not finished yet...

@sspross sspross closed this Dec 24, 2014
@sspross sspross reopened this Dec 24, 2014
@jeremyschlatter
Copy link
Contributor

Re: PyML, this is an issue other people have encountered as well. See issue #7. I have the same problem when testing on my Mac, so I've been running my tests in a virtual machine running Ubuntu.

@obukhov-sergey
Copy link
Member

Hi @sspross, thanks for your interest and the PR. talon has been migrated to scipy - you should be able to install / test it without any problems. If you run into any issues - let us know. I'm closing this PR now since (most of) it has been merged by @jeremyschlatter and the master branch has significantly changed since this PR has been submitted. Please submit a new one if you feel like something is missing.

@sspross
Copy link
Author

sspross commented Sep 11, 2015

ok thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants