chore: made setAuthentication public to allow credential changing #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jaetoole |
oleksandr-mykhailenko
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
So - we want to instantiate the Mailjet Client as a singleton with our master API credentials however for some of our 'customers' we want to be able to send requests dynamically to their sub-accounts without us having to re-instantiate a mailjet client constantly (we're going to be processing data at high volume so this will create a fair bit of overhead).
To allow us to switch credentials on the fly, we'd like the
setAuthenticationmethod to be public so we can just update our one instance for our sub-accounts instead of creating new clients constantly.Happy to hear your thoughts around this!