Rewrite WPFunctions methods [MAILPOET-1920] #1896
Conversation
amine-mp
force-pushed
the
rewrite-wp-functions
branch
7 times, most recently
from
57a6303
to
cd6ed76
Compare
|
I kept using |
lib/WP/Functions.php
Outdated
| } | ||
|
|
||
| function wpRemoteRetrieveResponseCode() { | ||
| return call_user_func_array('wp_remote_retrieve_response_code', func_get_args()); | ||
| function wcGetCustomerOrderCount($user_id) { |
There was a problem hiding this comment.
I'm thinking about WooCommerce functions. We already have a service WooCommerce\Helper
so I what about putting woo commerce functions into this helper? They are not WordPress functions.
There was a problem hiding this comment.
PHP Stan doesn't support function_exist check :( but the author mentions here that we can use is_callable as a workaround.
lib/WP/Functions.php
Outdated
| } | ||
|
|
||
| function wpRemoteRetrieveBody() { | ||
| return call_user_func_array('wp_remote_retrieve_body', func_get_args()); | ||
| function addAction() { |
There was a problem hiding this comment.
Add action has not dynamic number of arguments so I think this one can be refactored
There was a problem hiding this comment.
When I refactor addAction tests start failing and I don't know why, I kept it that way.
lib/WP/Functions.php
Outdated
| @@ -19,486 +19,499 @@ static function set(Functions $instance) { | |||
| self::$instance = $instance; | |||
| } | |||
|
|
|||
| function wpRemotePost() { | |||
| return call_user_func_array('wp_remote_post', func_get_args()); | |||
| function doAction() { | |||
There was a problem hiding this comment.
I think that for this and applyFilters we could do at least this:
/**
* @param string $tag
* @param mixed ...$args
* @return mixed
*/
function doAction($tag, ...$args) {
...
}
amine-mp
force-pushed
the
rewrite-wp-functions
branch
2 times, most recently
from
eb95d41
to
c68cee5
Compare
amine-mp
force-pushed
the
rewrite-wp-functions
branch
from
c68cee5
to
e6e5eaa
Compare
I rewrote the whole
WP/Functions.phpfile and sorted methods alphabetically.To review, please read the file as if it's a new one, because the diff doesn't make sense due to the reordering.