-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New WooCommerce segment: single order value [MAILPOET-4988] #4799
Conversation
…OrderValue [MAILPOET-4988]
064d659
to
662d429
Compare
@triple0t, right after I created this PR, I noticed a conflict due to a change that landed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, @rodrigoprimo I have one issue with this segment, always when I am making a new order I see just the last subscriber in the segment. So there is always one last subscriber even if I have a few subscribers with correct orders for the segment requirements. I thought that problem could be related to hpos enabled on this site, so I tried it on a new one. Example 2. I have two orders 72 and 110 in total |
Thanks for sharing the credentials to your site, @Aschepikov. I believe that the problem is that all the orders are associated with the same user. They do have different email addresses, but the customer is always "Test Test" (customer ID 1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG My fault, sorry. How I can forget about it?! GJ anyway!
Description
This PR adds a new WooCommerce segment called "single order value". It allows users to create segments based on the value of a single order made by customers. For example, customers that placed an order with a total value equal to or higher than $1000 in the last seven days.
Code review notes
I based this segment on the WooCommere total spent segment.
QA notes
To test this new segment:
/wp-admin/admin.php?page=mailpoet-segments#/new-segment
and create a new segment of the typesingle order value
.Linked PRs
N/A
Linked tickets
MAILPOET-4988
After-merge notes
N/A