Merge pull request #127 from mailru/finnan444-fix/nullable-date-time-…

…parse

Finnan444 fix/nullable date time parse

README.md

@@ -5,8 +5,10 @@ Yet another Golang SQL database driver for [Yandex ClickHouse](https://clickhous
 ## Key features
 
 * Uses official http interface
+* Compatibility with database/sql
 * Compatibility with [dbr](https://github.com/mailru/dbr)
 * Compatibility with [chproxy](https://github.com/Vertamedia/chproxy)
+* Compatibility with [clickhouse-bulk](https://github.com/nikepan/clickhouse-bulk)
 
 ## DSN
 ```
@@ -183,7 +185,7 @@ func main() {
 	}
 
 	ctx := context.Background()
-	rows, err := connect.QueryContext(context.WithValue(ctx, clickhouse.QueryID, "dummy-query-id"), `
+	rows, err = connect.QueryContext(context.WithValue(ctx, clickhouse.QueryID, "dummy-query-id"), `
 		SELECT
 			country_code,
 			os_id,

dataparser.go

@@ -184,7 +184,10 @@ func (p *nullableParser) Parse(s io.RuneScanner) (driver.Value, error) {
 		for {
 			r, _, err := s.ReadRune()
 			if err != nil {
-				return nil, nil
+				if err != io.EOF {
+					return nil, fmt.Errorf("unexpected error on ReadRune: %v", err)
+				}
+				break
 			}
 
 			runes += string(r)

dataparser_test.go

@@ -476,6 +476,24 @@ func TestParseDataNewNullableArray(t *testing.T) {
 			inputdata: `\N`,
 			output:    nil,
 		},
+		{
+			name:      "nullable null date",
+			inputtype: "Nullable(Date)",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable not null datetime",
+			inputtype: "Nullable(DateTime)",
+			inputdata: "2018-01-02 12:34:56",
+			output:    time.Date(2018, 1, 2, 12, 34, 56, 0, time.UTC),
+		},
+		{
+			name:      "nullable not null date",
+			inputtype: "Nullable(Date)",
+			inputdata: "2018-01-02",
+			output:    time.Date(2018, 1, 2, 0, 0, 0, 0, time.UTC),
+		},
 		{
 			name:      "nullable null enum",
 			inputtype: "Nullable(Enum8('hello' = 1, 'world' = 2))",