Go fmt + NULL (\N) values in tests;

deleted "not sure about safety ^^" comment (just a joke)
mailru · Feb 14, 2021 · fecfaea · fecfaea
1 parent 02ab5a4
commit fecfaea
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 2 deletions.
diff --git a/dataparser.go b/dataparser.go
@@ -112,7 +112,6 @@ func (p *nullableParser) Parse(s io.RuneScanner) (driver.Value, error) {
 		runes := ""
 
 		iter := 0
-		//not sure about safety ^^
 		for {
 			r, _, err := s.ReadRune()
 			if err != nil {

diff --git a/dataparser_test.go b/dataparser_test.go
@@ -394,6 +394,48 @@ func TestParseDataNewNullableArray(t *testing.T) {
 	t.Log(losAngeles, moscow)
 
 	testCases := []*testCase{
+		{
+			name:      "nullable null string",
+			inputtype: "Nullable(String)",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable null UInt64",
+			inputtype: "Nullable(UInt64)",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable null decimal",
+			inputtype: "Nullable(Decimal)",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable null datetime",
+			inputtype: "Nullable(DateTime)",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable null enum",
+			inputtype: "Nullable(Enum8('hello' = 1, 'world' = 2))",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable null uuid",
+			inputtype: "Nullable(UUID)",
+			inputdata: `\N`,
+			output:    nil,
+		},
+		{
+			name:      "nullable null Date",
+			inputtype: "Nullable(Date)",
+			inputdata: `\N`,
+			output:    nil,
+		},
 		{
 			name:      "nullable(decimal)",
 			inputtype: "Nullable(Decimal(9,4))",
@@ -574,7 +616,7 @@ func TestParseDataNewNullableArray(t *testing.T) {
 			name:          "malformed array(nullable(date))",
 			inputtype:     "Array(Nullable(Date))",
 			inputdata:     "['a000-00-00 00:00:00']",
-			output:        []time.Time{{},},
+			output:        []time.Time{{}},
 			failParseData: true,
 		},
 		{