[encoder] fix zero len array decoding #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaifullin
reviewed
Mar 22, 2018
encoder.go
Outdated
| @@ -136,6 +136,10 @@ func (d *textDecoder) Decode(t string, value []byte) (driver.Value, error) { | |||
| if strings.HasPrefix(t, "Array") { | |||
| if len(v) > 0 && v[0] == '[' && v[len(value)-1] == ']' { | |||
| items := strings.Split(v[1:len(value)-1], ",") | |||
There was a problem hiding this comment.
Thank you for PR.
I think the following construction will be better:
if len(v) > 0 && v[0] == '[' && v[len(v)-1] == '] {
var items []string
// check that array is not empty ([])
if len(v) > 2 {
items = strings.Split(v[1:len(v)-1], ",")
}
|
Thank you. the patch looks good to me. Could you also stash your commits, by using command |
- strings.Split with empty slice argument returns slice with 1 element which is empty string. without check len decoder crashes on empty numeric arrays - encoder test added - types test added
playboyko
force-pushed
the
fix_decode_empty_array
branch
from
b943152
to
94ccf71
Compare
|
@bgaifullin Could you please check if everything is ok now? |
|
Thanks. |
|
merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is empty string. without check len decoder crashes on empty
numeric arrays