fix decoding date and datetime value #26 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaifullin
reviewed
Jul 25, 2018
| return time.ParseInLocation(dateFormat, unquote(v), d.location) | ||
| uv := unquote(v) | ||
| if uv == "0000-00-00" { | ||
| return time.Date(0, 0, 0, 0, 0, 0, 0, time.UTC), nil |
There was a problem hiding this comment.
why UTC, I do not found in documentation, that it is in UTC.
there is only this in doc:
The minimum value is output as 0000-00-00.
Maybe need to create date in d.location instead of UTC?
| return time.ParseInLocation(timeFormat, unquote(v), d.location) | ||
| uv := unquote(v) | ||
| if uv == "0000-00-00 00:00:00" { | ||
| return time.Date(0, 0, 0, 0, 0, 0, 0, time.UTC), nil |
|
Clickhouse is not sensitive for all dates before 1970-01-02. I think using TZ in this case can be misleading. |
|
Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.