Enable decoding nested structures #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, I need some time to review this. |
|
Thank you for PR, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the projects I am working on we need to decode nested structures, like those that ClickHouse returns in response to this query:
select [(('name','AT'),('requests',15),('bytes',36585)),(('name','CA'),('requests',515),('bytes',31180966))].The PR adds support for that by replacing the current decoder with a parser implemented according to these and other docs on CH. Some types are still not supported (
Nullable).Also, using
Split()to parse arrays andregexpto unescape will never work properly (e.g.['hello\',','world']), so this PR fixes that problem too.