-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Active Directory you can have groups in groups support. #40
Microsoft Active Directory you can have groups in groups support. #40
Conversation
@johansmitsnl did you check that this change does not break the existing tests? |
3f9bf30
to
d2e53ad
Compare
@AndrewSav id did break one test because I forgot to add it. I updated the MR with a fix for the variable replacement check. Whould be ok now. |
@johansmitsnl may I suggest you try and run the tests locally? They still seems to have failed. |
New variables have to be added to setup.sh and they have to be exported so that they can be used in the templates. LDAP variables should go here: mailserver/rootfs/usr/local/bin/setup.sh Line 93 in 639ec3b
|
To support this you need to set the leaf group member option for it to follow the sub groups (if any).
d2e53ad
to
2e75c36
Compare
@SaraSmiseth thanks for the pointer. I'm having some difficulties installing docker (for some reason that is unclear to me yet) But I have added the suggested variables. |
@SaraSmiseth and @AndrewSav I fixed my docker install and tests pass locally as they also did here on Github I see. Is this good to merge or do you need more info? |
Looks good. I'm not exactly sure how the ldap stuff works, but I think we should add tests that use these new variables. You added the variables to init_ldap but I think these tests would work even if they were not set right? Maybe change the ldap configuration here or add a new config that uses group variables. Then we can use config with variables in ldap tests and the old config without the new variables in ldap2 tests. What about merging this as it is and add specific tests for this later? |
We do not have an AD in our tests to test against, so writing tests here could be quite tricky. On OpenLdap testing them could be pointless if they are added with the specific purpose of supporting AD. I'll try to merge and push a new build on the weekend if time permits and no one does that before me. |
I'm not so familiar with OpenLdap, but these variables are needed when you use groups in groups with users in them. When you don't walk through the groups you will end up with no users.
The result without the change is no users at all, with the change, User 1,2 and 3. From the Postfix manual:
Maybe some ldap people know how to translate this into a test? |
It does not appear that we have any ldap people here |
To support this you need to set the leaf group member option for it
to follow the sub groups (if any).
Thanks for submitting a pull request ! Please provide enough information so that others can review your changes.
For more information, see the
CONTRIBUTING
guide.Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Status
Todo List
How has this been tested ?
It has been tested against my AD. Not sure how to make the tests with OpenLDAP.