Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dkim Update #6

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Dkim Update #6

merged 3 commits into from
Apr 11, 2020

Conversation

SaraSmiseth
Copy link
Member

@SaraSmiseth SaraSmiseth commented Apr 11, 2020

Description

This PR adds the ability to specify the DKIM selector. If not provided, it falls back to the until now default mail. Also this fixes hardware#408 aswell.

In Addition, the OPENDKIM_KEY_LENGTH environment variable has been changed to DKIM_KEY_LENGTH to match the new DKIM_SELECTOR. For backwards compatibility it falls back to OPENDKIM_KEY_LENGTH if not defined (which again defaults to 1024).

With this PR the location of the DKIM keys has changed (with automatic migration). They are in the same folder but are now named selector.private.key and selector.public.key. So its not a breaking change, but if someone is automatically using the keys somewhere else, this might need adjustment to the new key names.

Fixes # (issue)

* Until now the DKIM selector was always mail and could not be changed.

* Now the DKIM selector can be changed and falls back to mail for backwards compatibility

Type of change

Please delete options that are not relevant.

* [x]  Bug fix (non-breaking change which fixes an issue)

* [x]  New feature (non-breaking change which adds functionality)

Status

* [x]  Ready

* [ ]  In development

* [ ]  Hold

Todo List

How has this been tested ?

This has been tested with the (updated) internal test suite.

See hardware#417

@SaraSmiseth SaraSmiseth merged commit 9cda13d into master Apr 11, 2020
@SaraSmiseth SaraSmiseth deleted the dkim branch April 11, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dkim/$DOMAIN/private.key is world readable
2 participants