Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing part 2 #9

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Testing part 2 #9

wants to merge 8 commits into from

Conversation

gisachris
Copy link
Collaborator

IN this PR 📦 We Made Unit Tests🧪 For the rest of the Functions In Our App.

In This pull request, we have implemented the editTask, clearTask, and UpdateTask function tests👍.

Requirements

  • Practise pair-programming 🧑‍🤝‍🧑.
  • Use jest framework for testing 🃏.
  • Create a test file(s) rest.test.js for a file(s) containing the following functions:
    • a function for editing 🖊️ the task description.
    • a function for updating 👍 an item's 'completed' status.
    • the "Clear all 💨 completed" function.
  • Make tests 🏷️ for the functions above.
  • group 🗳️ your tests using the describe() method.

Achievements

  • Practise pair-programming 🧑‍🤝‍🧑. ✅
  • Use jest framework for testing 🃏.✅
  • Create The necessary file and include all necessary functions that you want to test 🧪 .✅
  • Make tests 🏷️ for the functions above.✅
  • group 🗳️ your tests using the describe() method.✅

Conclusion

We look forward to hearing 👂 from you our CodeReviewer and any changes ♻️ we can make to improve the task at hand.😌

Copy link

@GzimAsani GzimAsani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 💯

There is nothing else to say than it's time to merge... 🥳

Cheers and Happy coding! 👏 💻 🍷
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • NA

Please be reminded to not open a new pull request after you get a review, only use the same one 💭

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants