Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show key ID in "Sign message with key" dialog as email is not unique. #339

Closed
wants to merge 1 commit into from

Conversation

lamby
Copy link
Contributor

@lamby lamby commented Oct 15, 2015

I also feel a bit "safer" when selecting a key when I can see the ID. I
slice to the last 8 characters at that matches the classic GnuPG style.

Signed-off-by: Chris Lamb chris@chris-lamb.co.uk

I also feel a bit "safer" when selecting a key when I can see the ID. I
slice to the last 8 characters at that matches the classic GnuPG style.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
@lamby
Copy link
Contributor Author

lamby commented May 1, 2016

Any objection to this PR, out of interest, or simply lack of time? :)

@toberndo
Copy link
Member

toberndo commented May 1, 2016

Sorry, forgot about this one. We are planning to change the key selection soon: the editor will then offer a field to enter the recipient email address and we will determine the key automatically. Also in the new pattern I don't see really the requirement for the key ID information and want to not overload the UI with information that is probably not relevant for the 98% use case. The goal should be: you want to send PGP encrypted to a certain contact, about the rest you don't need to care.

@toberndo toberndo closed this May 1, 2016
@toberndo
Copy link
Member

toberndo commented May 1, 2016

Oops, just realized we are in the sign dialog. Yes, here the key ID has relevance. Have to see how this fits into our editor refactoring.

@toberndo toberndo reopened this May 1, 2016
@lamby
Copy link
Contributor Author

lamby commented May 1, 2016

editor refactoring.

Seems safe to merge in the meantime though, no? :)

@toberndo
Copy link
Member

toberndo commented May 2, 2016

Merged.

@toberndo toberndo closed this May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants