Provides administrator the ability to combine quarantine reports into a single report #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a single report when used with user filters New constant QUARANTINE_FILTERS_COMBINED Bug Fixes
Apply fixes from StyleCI
Apply fixes from StyleCI
Apply fixes from StyleCI
endelwar
reviewed
Mar 14, 2017
| @@ -345,6 +345,7 @@ | |||
| foreach ($quarantine_list as $item) { | |||
| $list .= $item . ', '; | |||
| } | |||
| $list = substr($list,0,-2); | |||
There was a problem hiding this comment.
look at http://php.net/implode
There was a problem hiding this comment.
Yes, I'm not sure why I didn't use that the first time! Doh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608
Allows administrators to combine quarantine_reports into a single report containing all of the users filters.
Fixes a bug in the case of a single report per filter, where previously each filter report received quarantine mail for the parent user as well.