Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary output doesn't match #11

Open
main-- opened this issue May 21, 2020 · 0 comments
Open

Dictionary output doesn't match #11

main-- opened this issue May 21, 2020 · 0 comments
Milestone

Comments

@main--
Copy link
Owner

main-- commented May 21, 2020

Right now it looks like the output from dictionary mode works, but never matches the C implementation. The most important reason is that the C implementation maintains two distinct hashtables (one for the dictionary, one for the encoded input) whereas this implementation currently simply initializes the encoder hashtable with the dictionary.

Using two tables obviously gives better compression ratios. It's not clear to me however whether this is actually worth it. Perhaps it makes sense to give up on the goal of byte-perfect output when a dictionary is involved.

@main-- main-- added this to the 1.0 release milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant