Complete redesign of this gem #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| # | ||
| # @api public | ||
| # | ||
| class Project |
There was a problem hiding this comment.
Class Project has 26 methods (exceeds 20 allowed). Consider refactoring.
| # Returns `true` if `#changelog_path` is nil or is a valid regular file path | ||
| # @return [Boolean] | ||
| # @api private | ||
| def validate_changelog_path |
There was a problem hiding this comment.
Method validate_changelog_path has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
lib/create_github_release/release.rb
Outdated
| # | ||
| def initialize(tag, date, description) | ||
| def initialize(previous_tag, tag, created_on, changes, release_log_url) |
There was a problem hiding this comment.
Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
|
Code Climate has analyzed commit 1c9a683 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionsclass into two different classes:CommandLineOptionswhich just holds the command line options andProjectwhich has all the properties of the project that the release is being created for. TheOptionsclass was getting too complicated and this simplifies the class and testing.git loginstead of docker to get the change log