Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB Calculator: Logic for saving settings has been redesigned #2142

Closed
Gindi4711 opened this issue Sep 4, 2021 · 0 comments
Closed

GB Calculator: Logic for saving settings has been redesigned #2142

Gindi4711 opened this issue Sep 4, 2021 · 0 comments
Assignees
Labels
Extension - Idee / Idea Wäre das nicht was für die Extension? / Feature or Change Requests Nächstes Update / Next Update Feature/Bugfix is currently in development

Comments

@Gindi4711
Copy link
Collaborator

Gindi4711 commented Sep 4, 2021

For the GB calculator the logic for saving settings has been redesigned to make it more intuitive

Here is an overview of the old logic vs. the new one:
Screen

Reasons for the changes:
a) Most players do not need individual copy formats per building and will prefer if they do not like ending up with different copy formats per building.
For those players that DO need individual copy formats per building (for example if you use them in different 1.9 groups that have certain format requirements) there is an option in the settings menu to enable individual copy formats per GB, but default value will be off.
b) The place select settings that were reset at every refresh: This was initially not a problem, but with new options (like the copy button in main window) there have been more refreshes and options reset more often than expected. As a consequence the "Copy" button in main window will now use the selected format. A special use case would be:
.) When speedleveling select the option "All". Now you can create a copy string for all places after leveling the the building with the "Copy" button in the main window
c) Some settings like Ext1-5 and secure/trust existing payments are considered to be only valid for one specific building and one specific level and should be reset then opening another building.
d) There have been some cases where you could causes non intended behaviour. For example if you previously changed the player name of another player this name was also used for your own buildings. As players can now change their names I decided it makes more sense to drop the "change player name" feature for other buildings of other players as it will cause more accidents then it is useful.

Note: These changes mean that some settings will revert to default values once after the update (like the copy format).

@Gindi4711 Gindi4711 added Extension - Idee / Idea Wäre das nicht was für die Extension? / Feature or Change Requests Nächstes Update / Next Update Feature/Bugfix is currently in development labels Sep 4, 2021
@Gindi4711 Gindi4711 self-assigned this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension - Idee / Idea Wäre das nicht was für die Extension? / Feature or Change Requests Nächstes Update / Next Update Feature/Bugfix is currently in development
Projects
None yet
Development

No branches or pull requests

2 participants