Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-64 - Fix db user role for postgresql-users #65

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented Nov 2, 2020

Change postgresql-users user to postgres
Add new envars
Resolves #64

Signed-off-by: Ivan Milosevic iva@blokovi.com

@@ -53,6 +53,10 @@ spec:
value: {{ .Release.Name }}-envoy:{{ .Values.authn.grpcPort }}
- name: MF_TOKEN_RESET_ENDPOINT
value: "#/auth/reset-password"
- name: MF_USERS_ADMIN_EMAIL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin of what? Some general admin, or only PotgreSQL admin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No database. It's Mainflux default user, created on startup

https://github.com/mainflux/mainflux/blob/master/users/README.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see. Thanks.

Add new envars

Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit ef65c0d into absmach:master Nov 6, 2020
blokovi added a commit to blokovi/devops that referenced this pull request Apr 9, 2021
* Change postgresql-users user to postgres
Add new envars

Signed-off-by: Ivan Milosevic <iva@blokovi.com>

* Get envars values for connection to postgres databases from chart values

Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix user role for postgresql-users
2 participants