Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

loading state for search component #36

Closed
marcoow opened this issue May 20, 2018 · 0 comments · Fixed by #64
Closed

loading state for search component #36

marcoow opened this issue May 20, 2018 · 0 comments · Fixed by #64
Assignees

Comments

@marcoow
Copy link
Member

marcoow commented May 20, 2018

Currently, when showing the search component for the search term, the component shows the message "we could not find locations" initially before showing the actual data after that has been loaded. We need to show a loading state instead and only show the message if no data was found.

I think the best solution is probably to load all data in the parent PPMClient component and only pass the current state (e.g. in this case loading/loaded with data/loaded with no data) to the Search and Location child components.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants