Conversation
@marcoow this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm not seeing it but I think this is missing defaulting the label to what we currently use in the view.
OpenAQ.Locations.get_locations(lat, lon) | ||
locations = OpenAQ.Locations.get_locations(lat, lon) | ||
|
||
locations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be sufficient to do this only for the locations that don't have labels yet as that is very unlikely to change
Ah right - I set the label to the same value as the identifier initially - then update it. |
I'd do the defaulting in the view as otherwise you cannot really find out which one has been updated already and which one hasn't. |
closes #58