Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

Commit

Permalink
Merge pull request #5 from simplabs/did-activate
Browse files Browse the repository at this point in the history
Move notifications to `didActivate`-hook
  • Loading branch information
LevelbossMike committed Oct 21, 2015
2 parents b3578f4 + 6400c02 commit 214f884
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = {
}
},

didDeploy: function(context) {
didActivate: function(context) {
var preConfig = this.readConfig('configuredServices');
var userConfig = this.readConfig('services');

Expand Down
20 changes: 10 additions & 10 deletions tests/unit/index-nodetest.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ describe('notifications plugin', function() {
assert.equal(plugin.name, 'notifications');
});

describe('#didDeploy', function() {
it('implements the the `didDeploy`-hook', function() {
assert.ok(plugin.didDeploy);
describe('#didActivate', function() {
it('implements the `didActivate`-hook', function() {
assert.ok(plugin.didActivate);
});

describe('notifies services that are present as keys in the plugin config', function() {
Expand All @@ -69,7 +69,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isFulfilled(promise)
.then(function() {
Expand All @@ -87,7 +87,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isFulfilled(promise)
.then(function() {
Expand Down Expand Up @@ -118,7 +118,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isFulfilled(promise)
.then(function() {
Expand All @@ -139,7 +139,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isRejected(promise);
});
Expand All @@ -158,7 +158,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isFulfilled(promise)
.then(function() {
Expand All @@ -176,7 +176,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isFulfilled(promise)
.then(function() {
Expand All @@ -190,7 +190,7 @@ describe('notifications plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

var promise = plugin.didDeploy(context);
var promise = plugin.didActivate(context);

return assert.isFulfilled(promise);
});
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/lib/notify-nodetest.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('Notify', function() {
return assert.isRejected(promise);
});

it('logs when a success was successful', function() {
it('logs when a request was successful', function() {
var data = { apiKey: '12341234' };

var promise = subject.send(url, data);
Expand Down

0 comments on commit 214f884

Please sign in to comment.