This repository has been archived by the owner on Apr 17, 2020. It is now read-only.
fix deploy not failing with critical option #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
suggested changes
Sep 15, 2016
eredi93
force-pushed
the
js/fix-for-critical
branch
from
be44b96
to
9b160b1
Compare
|
added the tests, let me know if you think i need to change something else |
marcoow
approved these changes
Sep 15, 2016
|
@LevelbossMike: can you have a look as well? |
|
@LevelbossMike @marcoow any update on this? |
LevelbossMike
approved these changes
Sep 28, 2016
|
Sorry for taking so long. Overlooked this pr |
|
thank you. can you do a patch release too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now the deploy fails only if the request library throw an error eg: Timeouts, bad SSL certs etc.
with this change it also fials the deploy if the response code is not 2xx