Fix Object.assign error in IE11 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
reviewed
Jan 12, 2018
| const { keys, assign } = Object; | ||
| import { merge, assign as emberAssign } from '@ember/polyfills'; | ||
| const { keys } = Object; | ||
| const assign = Object.assign || emberAssign || merge; |
There was a problem hiding this comment.
I guess emberAssign would always be present so the fallback to || merge is not necessary? We could even just always use emberAssign.
There was a problem hiding this comment.
Ember.assign was added in Ember 2.5, so the merge fallback is there for older version support. It's a fairly common pattern, I've seen.
There was a problem hiding this comment.
Yes, you're right of course 🤦♂️
There was a problem hiding this comment.
Heh, no worries -- I do that all the time.
Thanks for the merge! :)
Merged
|
I rebased on |
marcoow
approved these changes
Jan 12, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
This just does the classic Ember.assign fallback if Object.assign isn't defined (i.e. in IE ;)