-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember-cli-babel to the latest version 🚀 #192
Conversation
@marcoow are you aware that ember-cli-babel@7 requires ember-cli@2.13+? |
no 😞 we're still pre-1.0 with ember-cookies - I'm not sure what that means for breaking changes like this; I think there are no breaking changes pre 1.0? |
see https://semver.org/#spec-item-4
so technically this is not a problem. the |
I'd say let's release this as 0.4 🚀 |
@Turbo87 @marcoow
What I think is happening is that another addon/dependency has Babel 6 declared as a dependency. This is causing the build to sometimes load Babel 6 and not Babel 7. I ended up downgrading. Do you think I should open an issue? |
I'd say an issue would be good for investigating - @Turbo87 is the expert in these things though. |
@Alonski linking addons screws up the |
Version 7.1.0 of ember-cli-babel was just published.
The version 7.1.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of ember-cli-babel.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 55 commits.
980428d
7.1.0
7e720b2
Update CHANGELOG for 7.0 and 7.1.
dd78011
Merge pull request #236 from buschtoens/feat/configurable-file-extensions
b13d111
feat: make processed file extensions configurable
0b83e42
7.0.0
fcf317f
Merge pull request #140 from babel/babel-7
d01d724
Prevent issues with @babel/preset-env getting unknown options.
1ea60c3
Merge branch 'master' into babel-7
6955f46
Drop support for ember-cli < 2.13.
eb03764
Merge changes from master...
b4528ff
Update test to properly match plugin style.
2ea0e47
Remove brittle (and unneeded) tests.
9671601
7.0.0-beta.5
1167211
Remove stray .only.
cf8f7ee
Fix issue with @babel/polyfill update.
There are 55 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴