Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli-babel to the latest version 🚀 #192

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Aug 29, 2018

Version 7.1.0 of ember-cli-babel was just published.

Dependency ember-cli-babel
Current Version 6.17.0
Type dependency

The version 7.1.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of ember-cli-babel.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 55 commits.

  • 980428d 7.1.0
  • 7e720b2 Update CHANGELOG for 7.0 and 7.1.
  • dd78011 Merge pull request #236 from buschtoens/feat/configurable-file-extensions
  • b13d111 feat: make processed file extensions configurable
  • 0b83e42 7.0.0
  • fcf317f Merge pull request #140 from babel/babel-7
  • d01d724 Prevent issues with @babel/preset-env getting unknown options.
  • 1ea60c3 Merge branch 'master' into babel-7
  • 6955f46 Drop support for ember-cli < 2.13.
  • eb03764 Merge changes from master...
  • b4528ff Update test to properly match plugin style.
  • 2ea0e47 Remove brittle (and unneeded) tests.
  • 9671601 7.0.0-beta.5
  • 1167211 Remove stray .only.
  • cf8f7ee Fix issue with @babel/polyfill update.

There are 55 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@marcoow marcoow merged commit dbbaac0 into master Aug 30, 2018
@marcoow marcoow deleted the greenkeeper/ember-cli-babel-7.1.0 branch August 30, 2018 08:04
@Turbo87
Copy link
Collaborator

Turbo87 commented Sep 6, 2018

@marcoow are you aware that ember-cli-babel@7 requires ember-cli@2.13+?

@marcoow
Copy link
Member

marcoow commented Sep 6, 2018

no 😞 we're still pre-1.0 with ember-cookies - I'm not sure what that means for breaking changes like this; I think there are no breaking changes pre 1.0?

@Turbo87
Copy link
Collaborator

Turbo87 commented Sep 6, 2018

I'm not sure what that means for breaking changes like this; I think there are no breaking changes pre 1.0?

see https://semver.org/#spec-item-4

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

so technically this is not a problem. the ^ versioning logic in npm works a little different though. it will only consider patch versions pre-1.0, but no minor bumps. so the best way forward would be to release this with a bumped minor version and a note about the changed compatibility requirements, or revert it and keep using Babel 6 for now.

@marcoow
Copy link
Member

marcoow commented Sep 6, 2018

I'd say let's release this as 0.4 🚀

@Alonski
Copy link

Alonski commented Aug 15, 2019

@Turbo87 @marcoow
Just want to say that I have been having issues using this release inside an addon that is linked to another app.
Steps:

  1. The addon and app have version ember-cookies: 0.4 set as a dependency.
  2. Inside the addon I yarn link
  3. Inside the app I yarn link addon
  4. I ember s in the app and get this error:
Build Error (broccoli-persistent-filter:Babel > [Babel: ember-cookies]) in ember-cookies/clear-all-cookies.js

Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel.

What I think is happening is that another addon/dependency has Babel 6 declared as a dependency. This is causing the build to sometimes load Babel 6 and not Babel 7.

I ended up downgrading. Do you think I should open an issue?

@marcoow
Copy link
Member

marcoow commented Aug 16, 2019

I'd say an issue would be good for investigating - @Turbo87 is the expert in these things though.

@Turbo87
Copy link
Collaborator

Turbo87 commented Aug 19, 2019

@Alonski linking addons screws up the node_modules dependency lookup so this is somewhat expected in some cases. make sure to use dependency-lint and that you only have one copy of each addon everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants