Add SameSite attribute support #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exelord
added a commit
to Exelord/ember-simple-auth
that referenced
this pull request
May 27, 2019
Adds SameSite support: mainmatter/ember-cookies#269
|
Makes sense 👍 Can you add test cases (see test cases for the other options)? |
|
Done :) |
|
Nice 👍 That only adds the test for the FastBoot case though - can you add one for when the same code runs in the browser as well? See https://github.com/simplabs/ember-cookies/blob/c516386620f605774626681fbf48c43b2074c757/tests/unit/services/cookies-test.js#L87 |
marcoow
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new cookie attribute called SameSite that we may want to support as well.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#Directives