Adjust ESLint config to work with v8 #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
reviewed
Feb 24, 2022
package.json
Outdated
| }, | ||
| "volta": { | ||
| "node": "12.22.10", | ||
| "yarn": "1.22.17" |
There was a problem hiding this comment.
I think Volta makes sense but would move this into a separate PR as it's unrelated to the ESLint fix. We'd also want to have Volta on CI then so it will actually use the right Node/Yarn versions there as well.
There was a problem hiding this comment.
oh no! sorry about that, intended to stash that change and not push 🙈
babel.config.js
Outdated
| return { | ||
| plugins: [...buildEmberPlugins(__dirname)], | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I'd be in favor of babelrc.js actually to keep it in line with eslintrc.js etc.
There was a problem hiding this comment.
@marcoow updated!
Merged
SergeAstapov
force-pushed
the
eslint-v8-setup
branch
from
12e6eec
to
61e7e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are necessary changes to have CI pass in addition to #701.