Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-auto-import@2 and webpack dev deps #729

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Mar 7, 2022

Currently, running ember test in local fails due to missing ember-auto-import@2 and webpack dependencies.

This makes local development or running tests cumbersome as you either need to run ember-try scenario (which is slow) or add deps manually (which is just inconvenient).

Currently, running `ember test` in local fails due to missing `ember-auto-import@2` and `webpack` dependencies
@SergeAstapov
Copy link
Contributor Author

Additionally, this prevents (see #723) upgrading ember-cli-fastboot-testing addon which uses ember-auto-import@2 hence this forces this addon to have ember-auto-import@2 in it's dev deps

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@marcoow marcoow merged commit fc6b256 into mainmatter:master Mar 8, 2022
@SergeAstapov SergeAstapov deleted the add-ember-auto-import branch March 8, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants