Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ember < 3.8 #730

Merged

Conversation

SergeAstapov
Copy link
Contributor

@marcoow wonder if you are up to this change, which indeed is breaking and may cause a churn but removes extra deps from the addon.

@marcoow
Copy link
Member

marcoow commented Mar 8, 2022

At some point sure but I'd see whether there are other things we want to merge before a major version change

@SergeAstapov
Copy link
Contributor Author

@marcoow we can do #732 if you'd like for the next major release. OR you may cut a major (let's say 0.6.0) and followed by v2 conversion which will be another major release.

Personally I don't have preference so would delegate to you as maintainer of the library.

@SergeAstapov SergeAstapov force-pushed the remove-ember-native-class-polyfill branch from 92d7b05 to f8c84c7 Compare March 8, 2022 15:47
@SergeAstapov SergeAstapov force-pushed the remove-ember-native-class-polyfill branch from f8c84c7 to 23060f9 Compare June 10, 2022 02:29
@SergeAstapov
Copy link
Contributor Author

@marcoow as we already did breaking changes in #747 and #748, do you think we can land this one as well and cut a new release?

@marcoow
Copy link
Member

marcoow commented Jun 21, 2022

yep 👍

@marcoow marcoow merged commit 7caa1d6 into mainmatter:master Jun 21, 2022
@SergeAstapov SergeAstapov deleted the remove-ember-native-class-polyfill branch June 21, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants