chore: extract test-app into own package #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
force-pushed
the
extract-test-app
branch
from
8c9f02f
to
78cdb7a
Compare
SergeAstapov
commented
May 19, 2022
|
@marcoow do you mind to take another look or delegate if there is anyone available? |
SergeAstapov
force-pushed
the
extract-test-app
branch
from
b6a5840
to
355c1e0
Compare
SergeAstapov
force-pushed
the
extract-test-app
branch
from
355c1e0
to
443f94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcoow this is continuation of the work started in #740
This PR introduces new package in the monorepo
test-appthat holds the dummy test app and tests.Removed from the
packages/ember-cookiesapp related code and from thepackages/test-appaddon related code (however tried to do just minimum changes for dependencies and eslintrc file).Some files marked as "new" nut they are actually copied from
packages/ember-cookiestopackages/test-app.