Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exports so TypeScript loads ambient types #889

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

SergeAstapov
Copy link
Contributor

Types added in #865 can not be parsed and loaded as TypeScript does not know where to look them up.

@SergeAstapov
Copy link
Contributor Author

looks like Run mainmatter/continue-on-error-comment@v1 task has failed in ember-canary job, seems unrelated.

@BobrImperator woudl you be able to restart CI or merge/release as is if looks good?

@And012
Copy link

And012 commented Dec 15, 2023

@BobrImperator This PR fixes type exports and will be very helpful if we merge this.

Copy link

github-actions bot commented Jan 8, 2024

Some tests with 'continue-on-error: true' have failed:

@BobrImperator
Copy link
Contributor

Thanks for the PR 🙏

@BobrImperator BobrImperator merged commit a49e9c5 into mainmatter:master Jan 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants