Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading/error substates #57

Closed
ryan0x44 opened this issue Jan 9, 2014 · 2 comments
Closed

Loading/error substates #57

ryan0x44 opened this issue Jan 9, 2014 · 2 comments
Milestone
0.1.0

Comments

@ryan0x44
Copy link

ryan0x44 commented Jan 9, 2014

I've got Ember.SimpleAuth working well, thanks for creating such a great library!

One thing I've noticed is upon clicking "Login", there is no visible loading icon/screen and no error handling.

I'm not sure if there is an option to implement this already, but maybe we could make use of the Ember Loading and Error substates?
@marcoow
Copy link
Member

marcoow commented Jan 9, 2014

Error handling will come with the 0.1.0 release (next week or in 2 weeks I think). The loading substate couldn't really be used for this as there's no route transition (which is necessary for using the loading substate as far as I know). To display some sort of activity indicator you'd have to override the login action of your login controller.

@ryan0x44
Copy link
Author

ryan0x44 commented Jan 9, 2014

Awesome! 👍 Looking forward to 0.1.0 then, thanks!

@marcoow marcoow closed this as completed Jan 9, 2014
marcoow pushed a commit that referenced this issue Feb 8, 2018
@Turbo87
Merge pull request #57 from Turbo87/add-support-for-component-test-se…
817c645 
…lectors

Add support for component data-test-* attributes without values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@marcoow @ryan0x44