Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support MAC tokens in OAuth2 authorizer #59

Closed
marcoow opened this issue Jan 10, 2014 · 2 comments
Closed

support MAC tokens in OAuth2 authorizer #59

marcoow opened this issue Jan 10, 2014 · 2 comments
Assignees
@marcoow
Labels
enhancement wontfix

Comments

@marcoow
Copy link
Member

marcoow commented Jan 10, 2014

simply check token type and add correct token accordingly
@ghost ghost assigned marcoow Jan 10, 2014
@marcoow
Copy link
Member Author

marcoow commented Jan 10, 2014

see e.g. this explanation: http://java.dzone.com/articles/oauth-20-bearer-token-profile

@marcoow marcoow removed this from the 0.1.next milestone Feb 18, 2014
@marcoow
Copy link
Member Author

marcoow commented Feb 21, 2014

It's most likely not a good idea to make this part of the core library as it would add all sorts of crypto/hashing dependencies that would just unnecessarily bloat the library for most users. Also nobody has really requested this yet. If the need arises to have this, it would be the best solution to have it in an additional library that would augment the default OAuth2 strategy that's included in the core lib (maybe that's a good approach for most authenticators).

@marcoow marcoow closed this as completed Feb 21, 2014
marcoow pushed a commit that referenced this issue Feb 8, 2018
@bgentry @Turbo87
attributeBindings is frozen, slice it before push (#59)
1c03080 
As noted in the Ember v2.11 release notes, concatenated properties such
as attributeBindings are frozen in debug builds. This means we cannot
push directly onto the attributeBindings array without first copying it
via slice.

Without this change, users may see errors like this when the
`attributeBindings.push()` call is made:

Uncaught TypeError: Can't add property 2, object is not extensible

References:

emberjs/ember.js#14389
emberjs/ember.js#14601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoow marcoow

Labels
enhancement wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcoow